Repository navigation
test(nextjs): Fix flaky nextjs-16 metrics tests - #25517
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
marked this pull request as ready for review
October 19, 2026 14:10
mydea
requested review from
a team,
chargome and
s1gr1d
and removed request for
a team
October 19, 2026 14:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Should emit metrics from server and clienttest innextjs-16intermittently failed because the clienttest.page.countmetric had nospan_id. Metrics only get aspan_idwhen a span is active at capture time (packages/core/src/metrics/internal.ts), and the click handler relied on the pageload idle span still being open when Playwright clicked. That's a timing race, and the slowernext dev --webpackrun is where it keeps losing: all four recent failures came from thedevelopment-webpackpass.The metrics page now emits the client metrics inside an explicit
Sentry.startSpan, so a span is always active and the existingspan_idassertions stay strict. The same fix is applied tonextjs-16-static, which has an identical page and assertions.via Francesco Gringl-Novy.
--
View Junior Session [Sentry]