Repository navigation
fix(solidstart): Read server action route from the request's root span - #25513
Merged
Merged
Conversation
Since Nitro's h3 route handler opens a `handler` span instead of a nested `http.server` span (#25295), the active span during a server function call has no `url.path`, so `withServerActionInstrumentation` no longer recognized `/_server` requests and stopped renaming the segment to the server action name. Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
marked this pull request as ready for review
October 19, 2026 14:07
mydea
requested review from
andreiborza,
chargome and
s1gr1d
and removed request for
a team
October 19, 2026 14:07
andreiborza
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
E2E solidstart-2failure ondevelop. Since #25295, the "sends a server action span on client navigation" test times out because thePOST getPrefecturesegment is never sent.Root cause: After #25295, Nitro's h3 route handler opens a
handlerspan instead of a nestedhttp.serverspan.withServerActionInstrumentationdecided whether to rename the segment by reading the attributes of the active span. Now that span is thehandlerspan, which has nourl.path, so the/_servercheck never matched and the server action name was never applied.The fix reads the attributes from the root span instead. That is the request's
http.serverspan, the onesetHttpServerSpanRouteAttributerenames, so the check and the rename now target the same span whatever the framework nests in between.Locally,
solidstart-2E2E fails 1/9 (this test) without the change and passes 9/9 with it.via Francesco Gringl-Novy.
--
View Junior Session [Sentry]