Repository navigation
Conversation
`nestIntegration({ monitorCronJobs: true })` sends check-ins for every
`@Cron()` method, with the schedule from `@Cron()` as monitor config.
The slug is the `@Cron()` name, else `ClassName.methodName`.
`excludeCronJobs` skips jobs; methods with `@SentryCron` keep their slug.
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Description
Adds
monitorCronJobstonestIntegration. When enabled, every@Cron()method of@nestjs/schedulesends check-ins, with the schedule and time zone of@Cron()as the monitor config (same conversion as@SentryCronin #25013). It is off by default.The slug is the
nameoption of@Cron(), orClassName.methodNamewithout one.excludeCronJobsmatches slugs (strings exactly, or regexes). Methods that also have@SentryCronkeep their explicit slug and send one set of check-ins. Schedules Sentry would read differently (for example, a job that runs every 10 seconds) check in without a config.@Cron()with aDateruns once and is not monitored. This uses the@Croninstrumentation of the orchestrion channel injection, so it needsenableRuntimeChannelInjection(on by default).Testing
Unit tests for slugs, exclusion,
@SentryCronin both decorator orders, and error check-ins; an e2e test innestjs-basic.Stacked on #25013.