Repository navigation
Conversation
s1gr1d
added this pull request to stack #25455
October 16, 2026 12:14
Contributor
size-limit report 📦
|
s1gr1d
force-pushed
the
sig/hono-5--1-classifier
branch
from
October 16, 2026 12:29
6d659c1 to
2b08611
Compare
s1gr1d
marked this pull request as ready for review
October 16, 2026 12:36
The Context hook and wrapSubAppMiddleware each had their own copy of the rule that tells middleware from route handlers. Move the rule to getMiddlewareFlags() and check the shape of the match result entries before the hook reads them. No behavior change. Refs #25223 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
s1gr1d
force-pushed
the
sig/hono-5--1-classifier
branch
from
October 16, 2026 12:44
2b08611 to
1de41db
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for #25454. No behavior change.
wrapSubAppMiddlewarehad their own copies of the rule that tells middleware from route handlers. Both now callgetMiddlewareFlags()isMatchedHandlerList()), instead of optional chaining at each stepRef #25223