Repository navigation
test(react): Fix flaky react-router-6 aborted SSE console assertion - #25398
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 15, 2026 12:17
s1gr1d
approved these changes
Oct 15, 2026
s1gr1d
left a comment
Member
There was a problem hiding this comment.
We could probably use page.waitForEvent for this instead, wdyt?
Member
Author
is this better than expect.poll? it would also just poll the array I guess? 🤔 |
Chromium in Playwright 1.64 rejects the aborted read with the signal's abort
reason ("signal is aborted without reason") instead of "BodyStreamBuffer was
aborted". Both are AbortErrors.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Waits for sse streaming when sse has been explicitly abortedtest checked for the abort error in the console immediately after the spans arrived. Thesse fetch callspan ends whenfetchresolves, but theconsole.erroronly happens after the abortedreader.read()rejects, and Playwright delivers console events asynchronously. Nothing orders the two, so the console message sometimes hadn't been recorded yet. The assertion now polls for it.The assertion also matched on
BodyStreamBuffer was aborted, which only older Chromium logs. Since Playwright 1.64 (#25382), Chromium rejects the read with the signal's abort reason (AbortError: signal is aborted without reason), so the test failed on every run there. It now matches anyAbortError.🤖 Generated with Claude Code