Repository navigation
Conversation
adityareddy-dev
marked this pull request as ready for review
October 15, 2026 06:24
adityareddy-dev
requested review from
JPeer264 and
mydea
and removed request for
a team
October 15, 2026 06:24
isaacs
approved these changes
Oct 18, 2026
isaacs
left a comment
Member
There was a problem hiding this comment.
This is good, thanks!
I think it makes sense to close the issue, since moving the spotlightIntegration here from the Cloudflare package would be a somewhat bigger lift.
It is fetch-based, so it would probably work if we move it to a shared entry. If we decide we want it on Vercel Edge, we can open a separate follow-up issue for that move. It's a refactor across packages, not a missing re-export, and so keeping #24043 open for it would leave a mostly-done issue sitting in the backlog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vercel Edge entry point is missing
setConversationId,updateSpanName,growthbookIntegrationandinstrumentCreateReactAgent, even though their implementations work without diagnostics channels. Re-export them through the existing runtime-safe entries and add public-entry tests for their behavior.This covers the portable helpers in #24043. Vercel AI and Prisma need diagnostics channels, the Cloudflare HTTP integration is consumed by its request wrapper, and the existing fetch-based Spotlight integration lives in the Cloudflare package rather than a shared entry point, so those remain separate work.
Fixes #24043