feat(react-router)!: Remove unstable_sentryVitePluginOptions - #23374
Draft
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
unstable_sentryVitePluginOptionsfrom the React Router build options.Net deletion of ~430 lines: the hatch could contradict
sentryOnBuildEnd, so a guard, aconsole.warnand an "explicitundefinederases the unstable value" workaround all existed purely to contain it. All three go.While removing it,
sentryUrlandheadersturned out to reach theSentryCliconstructor only through the hatch, so self-hosted setups had no supported way to point the buildEnd upload at their instance. They are now read from the top-level config — thereact-router-sourcemapse2e app depended on exactly this, viaunstable_sentryVitePluginOptions.url.Tests asserting hatch-vs-top-level precedence are deleted; the ones asserting real invariants (source maps stay disabled for the Vite plugin,
filesToDeleteAfterUploadnever forwarded,metaFrameworkpinned) are rewritten against top-level options. The #22929 regression coverage is preserved in both the unit tests and the e2e app.Fixes #23344