feat(core): Expose sentry.op attribute to samplers - #23354
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
andreiborza
marked this pull request as ready for review
August 12, 2026 13:04
Lms24
approved these changes
Aug 12, 2026
Member
|
good catch! |
nicohrubec
approved these changes
Aug 12, 2026
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0ffb790. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Folds the
opoption into the span attributes before sampling, so atracesSamplerseessentry.opin the attributes. An explicitsentry.opattribute wins over the option.Why
The OpenTelemetry startSpan implementations expose
sentry.opto samplers, but core only adds it after the sampling decision. This aligns core with that behavior, extracted from #23198.