feat(nuxt)!: Remove unstable_sentryBundlerPluginOptions - #23351
Draft
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86d5913. Configure here.
| moduleOptions: SentryNuxtModuleOptions, | ||
| shouldDeleteFilesFallback?: { client: boolean; server: boolean }, | ||
| ): SentryVitePluginOptions | SentryRollupPluginOptions { | ||
| warnOnRemovedBuildOptions(moduleOptions, ['unstable_sentryBundlerPluginOptions']); |
There was a problem hiding this comment.
Removal warning fires twice
Low Severity
warnOnRemovedBuildOptions runs inside getPluginOptions, which a normal production Nuxt build invokes twice — once for the Vite plugin and once for the Nitro Rollup plugin. Users who still set unstable_sentryBundlerPluginOptions therefore see the same removal warning duplicated.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 86d5913. Configure here.
| filesToDeleteAfterUpload, | ||
| rewriteSources: sourcemapsOptions.rewriteSources ?? normalizePath, | ||
| ...moduleOptions?.unstable_sentryBundlerPluginOptions?.sourcemaps, | ||
| resolveSourceMap: sourcemapsOptions.resolveSourceMap, |
There was a problem hiding this comment.
Missing integration or E2E test
Low Severity
This feat PR only adds unit and type tests for the removal warning and option pass-through. Per the PR Review Guidelines for Cursor Bot testing conventions, feat PRs need at least one integration or E2E test; neither is present here. Flagged because it was mentioned in this rules file.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 86d5913. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
unstable_sentryBundlerPluginOptionsfrom the Nuxt module options.Everything it exposed is reachable as a top-level build option. Adds a build-time warning for plain JS configs, where TypeScript cannot catch the removed key.
closes #23340