fix(core): Apply capture mechanism to originally captured exception - #23320
Open
s1gr1d wants to merge 4 commits into
Open
fix(core): Apply capture mechanism to originally captured exception#23320s1gr1d wants to merge 4 commits into
s1gr1d wants to merge 4 commits into
Conversation
s1gr1d
requested review from
Lms24,
logaretm and
msonnb
and removed request for
a team
August 12, 2026 08:41
Contributor
size-limit report 📦
|
s1gr1d
requested review from
JPeer264 and
mydea
and removed request for
a team
August 12, 2026 09:23
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit dad2fdc. Configure here.
Lms24
approved these changes
Aug 12, 2026
Lms24
left a comment
Member
There was a problem hiding this comment.
This is a really nice fix! Thanks for taking this on!
msonnb
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix custom exception mechanisms being applied to the deepest linked cause instead of the originally captured error.
LinkedErrorsprepends causes before capture hints are applied, so the mechanism could overwrite a cause'schainedmetadata and incorrectly mark it as unhandled. Capture mechanisms now target the captured exception (identified byexception_id === 0for exception groups) while preserving existing behavior for ordinary events.Previous Behavior
In this scenario:
...the mechanism of would be applied not to "Failure 3" but "Failure 1":
References
Also came up in this comment from 2025:
Related to this PR (added tests to showcase problem):
cause#23244