Skip to content

fix(react-router): Use react-router's own instrumentation types instead of a mirrored copy - #23310

Open
logaretm wants to merge 1 commit into
developfrom
awad/react-router-instrumentation-types-drift
Open

fix(react-router): Use react-router's own instrumentation types instead of a mirrored copy#23310
logaretm wants to merge 1 commit into
developfrom
awad/react-router-instrumentation-types-drift

Conversation

@logaretm

@logaretm logaretm commented Aug 11, 2026

Copy link
Copy Markdown
Member

Types createSentryServerInstrumentation() / createSentryClientInstrumentation() against react-router's own exported ServerInstrumentation / ClientInstrumentation types instead of a hand-maintained mirror that had drifted.

The vendored types were internal-only, so deleting it isn't a public API change, and runtime should be unaffected.

closes #23265

@logaretm

Copy link
Copy Markdown
Member Author

bugbot run

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.29 kB - -
@sentry/browser - with treeshaking flags 28.47 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.8 kB - -
@sentry/browser (incl. Tracing) 48.54 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.56 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.44 kB - -
@sentry/browser (incl. Tracing, Replay) 87.95 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.36 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.66 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.36 kB - -
@sentry/browser (incl. Feedback) 47.61 kB - -
@sentry/browser (incl. sendFeedback) 35.11 kB - -
@sentry/browser (incl. FeedbackAsync) 40.26 kB - -
@sentry/browser (incl. Metrics) 31.28 kB - -
@sentry/browser (incl. Logs) 31.53 kB - -
@sentry/browser (incl. Metrics & Logs) 32.2 kB - -
@sentry/react 32.09 kB - -
@sentry/react (incl. Tracing) 50.73 kB - -
@sentry/vue 35.34 kB - -
@sentry/vue (incl. Tracing) 50.5 kB - -
@sentry/svelte 30.31 kB - -
CDN Bundle 31.59 kB - -
CDN Bundle (incl. Tracing) 48.87 kB - -
CDN Bundle (incl. Logs, Metrics) 33.8 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.83 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.34 kB - -
CDN Bundle (incl. Tracing, Replay) 86.46 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.17 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.14 kB - -
CDN Bundle - uncompressed 93.77 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.66 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.17 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.46 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.1 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.92 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.7 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.61 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.38 kB - -
@sentry/nextjs (client) 53.29 kB - -
@sentry/sveltekit (client) 48.96 kB - -
@sentry/core/server 65.44 kB - -
@sentry/core/browser 51.8 kB - -
@sentry/node 117.98 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.09 kB +0.01% +1 B 🔺
@sentry/aws-serverless 91.5 kB - -
@sentry/cloudflare (withSentry) - minified 214.1 kB - -
@sentry/cloudflare (withSentry) 528.64 kB - -

View base workflow run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 85f2783. Configure here.

Comment thread packages/react-router/src/client/createClientInstrumentation.ts
@logaretm
logaretm marked this pull request as ready for review August 11, 2026 19:12
@logaretm
logaretm requested a review from a team as a code owner August 11, 2026 19:12
@logaretm
logaretm requested review from chargome and s1gr1d and removed request for a team August 11, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant