feat(browser)!: Extract interaction spans into new interactionsIntegration - #23295
Draft
msonnb wants to merge 3 commits into
Draft
feat(browser)!: Extract interaction spans into new interactionsIntegration#23295msonnb wants to merge 3 commits into
interactionsIntegration#23295msonnb wants to merge 3 commits into
Conversation
…ration` Interaction spans (`ui.action.click` idle spans and `ui.interaction.click` event-timing spans) are no longer part of `browserTracingIntegration`. They move into a standalone, opt-in `interactionsIntegration`. The experimental `_experiments.enableInteractions` option is removed. As it was the only experimental option, `browserTracingIntegration` no longer accepts an `_experiments` object at all. The `idleTimeout`, `finalTimeout` and `childSpanTimeout` options for interaction spans are configured on the new integration instead of being inherited, using the same defaults. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e5e9450. Configure here.
| }, | ||
| }, | ||
| idleSpanOptions, | ||
| ); |
There was a problem hiding this comment.
Missing origin on idle spans
Medium Severity
startIdleSpan for ui.action.click does not set SENTRY_ORIGIN / sentry.origin. Spans then default to manual, so auto-instrumented interaction idle spans are mis-attributed. Child ui.interaction.click spans already set origin correctly. This violates the PR review rule that every startSpan API call must set a proper span origin (see https://develop.sentry.dev/sdk/telemetry/traces/trace-origin/).
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit e5e9450. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This extracts interaction spans into a new opt-in (standalone)
interactionsIntegration.Why
Interaction idle spans have been experimental since v7. We don't expect to promote them to stable, but they still cost bundle size for every user of
browserTracingIntegration.closes #22353