Skip to content

ref(server-utils): Remove unused AI client types #23289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicohrubec wants to merge 1 commit into from
Open

ref(server-utils): Remove unused AI client types #23289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/server-utils/src/ai/anthropic-ai/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,6 @@ type SuccessfulResponse = {

export type AnthropicAiResponse = SuccessfulResponse | MessageError;

/**
* Basic interface for Anthropic AI client with only the instrumented methods
* This provides type safety while being generic enough to work with different client implementations
*/
export interface AnthropicAiClient {
messages?: {
create: (...args: unknown[]) => Promise<AnthropicAiResponse>;
};
completions?: {
create: (...args: unknown[]) => Promise<AnthropicAiResponse>;
};
}

/**
* Anthropic AI Integration interface for type safety
*/
Expand Down
28 changes: 0 additions & 28 deletions packages/server-utils/src/ai/google-genai/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,33 +145,5 @@ type GenerateContentResponse = {
usageMetadata?: GenerateContentResponseUsageMetadata;
};

/**
* Basic interface for Google GenAI client with only the instrumented methods
* This provides type safety while being generic enough to work with different client implementations
*/
export interface GoogleGenAIClient {
models: {
generateContent: (...args: unknown[]) => Promise<GenerateContentResponse>;
// https://googleapis.github.io/js-genai/release_docs/classes/models.Models.html#generatecontentstream
// eslint-disable-next-line @typescript-eslint/no-explicit-any
generateContentStream: (...args: unknown[]) => Promise<AsyncGenerator<GenerateContentResponse, any, unknown>>;
// https://googleapis.github.io/js-genai/release_docs/classes/models.Models.html#embedcontent
embedContent: (...args: unknown[]) => Promise<unknown>;
};
chats: {
create: (...args: unknown[]) => GoogleGenAIChat;
};
}

/**
* Google GenAI Chat interface for chat instances created via chats.create()
*/
export interface GoogleGenAIChat {
sendMessage: (...args: unknown[]) => Promise<GenerateContentResponse>;
// https://googleapis.github.io/js-genai/release_docs/classes/chats.Chat.html#sendmessagestream
// eslint-disable-next-line @typescript-eslint/no-explicit-any
sendMessageStream: (...args: unknown[]) => Promise<AsyncGenerator<GenerateContentResponse, any, unknown>>;
}

// Export the response type for use in instrumentation
export type GoogleGenAIResponse = GenerateContentResponse;
11 changes: 0 additions & 11 deletions packages/server-utils/src/ai/openai/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,6 @@ export type AttributeValue =
/** Options for the OpenAI integration. */
export type OpenAiOptions = GenAiOptions;

export interface OpenAiClient {
responses?: {
create: (...args: unknown[]) => Promise<unknown>;
};
chat?: {
completions?: {
create: (...args: unknown[]) => Promise<unknown>;
};
};
}

/**
* @see https://platform.openai.com/docs/api-reference/chat/object
*/
Expand Down
10 changes: 0 additions & 10 deletions packages/server-utils/src/ai/workers-ai/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,6 @@ import type { GenAiOptions } from '../core/utils';
/** Options for the Workers AI integration. */
export type WorkersAiOptions = GenAiOptions;

/**
* Minimal shape of the Cloudflare Workers AI binding (`env.AI`).
* We only rely on the `run` method, everything else is passed through untouched.
* @see https://developers.cloudflare.com/workers-ai/configuration/bindings/
*/
export interface WorkersAiClient {
run: (model: string, inputs: Record<string, unknown>, options?: Record<string, unknown>) => Promise<unknown>;
[key: string]: unknown;
}

/**
* The token usage reported by Workers AI text generation models.
*/
Expand Down
6 changes: 2 additions & 4 deletions packages/server-utils/test/ai/tracing/openai-integration-functions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { beforeEach, describe, expect, it } from 'vitest';
import type { OpenAiClient } from '../../../src/ai/openai/types';
import { instrumentOpenAiClient } from '../../../src/ai/openai';

interface FullOpenAIClient {
Expand Down Expand Up @@ -103,12 +102,11 @@ class MockOpenAIClient implements FullOpenAIClient {

describe('OpenAI Integration Private Field Fix', () => {
let mockClient: MockOpenAIClient;
let instrumentedClient: FullOpenAIClient & OpenAiClient;
let instrumentedClient: FullOpenAIClient;

beforeEach(() => {
mockClient = new MockOpenAIClient();
instrumentedClient = instrumentOpenAiClient(mockClient as unknown as OpenAiClient) as FullOpenAIClient &
OpenAiClient;
instrumentedClient = instrumentOpenAiClient(mockClient as unknown as object) as FullOpenAIClient;
});

it('should work with instrumented methods (chat.completions.create)', async () => {
Expand Down
Loading