feat(core)!: Return StreamedSpanJSON from spanToJSON - #23238
Draft
Lms24 wants to merge 2 commits into
Draft
Conversation
Swaps the two span serialization helpers: - `spanToJSON` now returns `StreamedSpanJSON`, the same shape users already get in `beforeSendSpan`. - The previous static `SpanJSON` behavior is available as `spanToStaticSpanJSON`, which is what users opting out of span streaming should switch to. This commit is a pure identifier rename on top of the preceding migration — no call site changes shape, because every internal consumer was already moved onto the streamed representation. That makes the diff mechanically verifiable. `spanToStaticSpanJSON` is also re-exported from the SDK packages that already re-export `spanToJSON` (node, browser, vercel-edge, cloudflare, bun, deno, and the meta-frameworks). Those barrels enumerate their exports rather than re-exporting `@sentry/core` wholesale, so without this the migration guide's advice to switch to `spanToStaticSpanJSON` would not be followable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e900a8. Configure here.
Contributor
size-limit report 📦
|
`spanToStreamedSpanJSON` was public API in v10 (exported from `@sentry/core`), so its removal needs an explicit migration path. It is now equivalent to `spanToJSON`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the two span serialization helpers:
spanToJSONnow returnsStreamedSpanJSON— the same shape users already get inbeforeSendSpan— and the previous static behavior is available asspanToStaticSpanJSON.Stacked on #23237, which already moved every internal consumer onto the streamed representation. That makes this PR a pure identifier rename: no call site changes shape, so despite the file count the diff is mechanically verifiable. Reviewing
packages/core/src/utils/spanUtils.ts,packages/core/src/types/span.tsandMIGRATION.mdcovers the actual API change; the rest is the rename.One addition beyond the rename:
spanToStaticSpanJSONis re-exported from the SDK packages that already re-exportspanToJSON(node, browser, vercel-edge, cloudflare, bun, deno and the meta-frameworks). Those barrels enumerate their exports rather than re-exporting@sentry/corewholesale, so without it the migration guide's advice to switch tospanToStaticSpanJSONwould not have been followable.