Skip to content

ref(react-router)!: Remove deprecated Vite build options and back-compat shims - #23229

Merged
RulaKhaled merged 3 commits into
developfrom
rolaabuhasna/js-3031-react-router-remove-deprecated-vite-build-options-back
Aug 10, 2026
Merged

ref(react-router)!: Remove deprecated Vite build options and back-compat shims#23229
RulaKhaled merged 3 commits into
developfrom
rolaabuhasna/js-3031-react-router-remove-deprecated-vite-build-options-back

Conversation

@RulaKhaled

Copy link
Copy Markdown
Collaborator

Removes the deprecated Vite build options and back-compat shims in @sentry/react-router that were kept to avoid breaking changes.

Closes ##22251

@linear-code

linear-code Bot commented Aug 10, 2026

Copy link
Copy Markdown

JS-3031

@RulaKhaled RulaKhaled changed the title ref(react-router)Remove deprecated Vite build options and back-compat shims ref(react-router)!: Remove deprecated Vite build options and back-compat shims Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.35 kB - -
@sentry/browser - with treeshaking flags 28.52 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.85 kB - -
@sentry/browser (incl. Tracing) 48.61 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.62 kB - -
@sentry/browser (incl. Tracing, Profiling) 53.46 kB - -
@sentry/browser (incl. Tracing, Replay) 88.04 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.45 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.77 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.45 kB - -
@sentry/browser (incl. Feedback) 47.69 kB - -
@sentry/browser (incl. sendFeedback) 35.18 kB - -
@sentry/browser (incl. FeedbackAsync) 40.33 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.66 kB - -
@sentry/browser (incl. Metrics & Logs) 32.34 kB - -
@sentry/react 32.14 kB - -
@sentry/react (incl. Tracing) 50.82 kB - -
@sentry/vue 35.45 kB - -
@sentry/vue (incl. Tracing) 50.59 kB - -
@sentry/svelte 30.38 kB - -
CDN Bundle 31.61 kB - -
CDN Bundle (incl. Tracing) 48.92 kB - -
CDN Bundle (incl. Logs, Metrics) 33.84 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.88 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.38 kB - -
CDN Bundle (incl. Tracing, Replay) 86.49 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.21 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.18 kB - -
CDN Bundle - uncompressed 93.95 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.92 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.42 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.78 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.34 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.17 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.01 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.87 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.7 kB - -
@sentry/nextjs (client) 53.38 kB - -
@sentry/sveltekit (client) 49.03 kB - -
@sentry/core/server 65.6 kB - -
@sentry/core/browser 51.92 kB - -
@sentry/node 118.46 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.57 kB - -
@sentry/aws-serverless 91.94 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 214.7 kB - -
@sentry/cloudflare (withSentry) 530.23 kB - -

View base workflow run

@RulaKhaled
RulaKhaled marked this pull request as ready for review August 10, 2026 12:52
@RulaKhaled
RulaKhaled requested a review from a team as a code owner August 10, 2026 12:52
@RulaKhaled
RulaKhaled requested review from chargome, nicohrubec and s1gr1d and removed request for a team August 10, 2026 12:52
@chargome

Copy link
Copy Markdown
Member

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 557430a. Configure here.

Comment thread MIGRATION.md Outdated
});
```

### `@sentry/react-router`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to go into https://github.com/getsentry/sentry-javascript/blob/develop/docs/migration/v11-end-state.md

Also let's trim this down a bit, imo we can rm the code snippet here.

@RulaKhaled
RulaKhaled requested a review from chargome August 10, 2026 14:09

@chargome chargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RulaKhaled
RulaKhaled merged commit 1a42045 into develop Aug 10, 2026
273 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-3031-react-router-remove-deprecated-vite-build-options-back branch August 10, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants