Skip to content

ref(node): Remove OpenTelemetryServerRuntimeOptions type - #23228

Merged
andreiborza merged 2 commits into
developfrom
ab/remove-opentelemetry-server-runtime-options
Aug 10, 2026
Merged

ref(node): Remove OpenTelemetryServerRuntimeOptions type#23228
andreiborza merged 2 commits into
developfrom
ab/remove-opentelemetry-server-runtime-options

Conversation

@andreiborza

@andreiborza andreiborza commented Aug 10, 2026

Copy link
Copy Markdown
Member

What

Removes the OpenTelemetryServerRuntimeOptions type. Its only remaining option, enableOpenTelemetrySetup, now lives directly on the SDK-specific option types.

  • BaseNodeOptions declares enableOpenTelemetrySetup and extends ServerRuntimeOptions directly.
  • BaseBunOptions declares its own enableOpenTelemetrySetup, matching how the Deno, Cloudflare and Vercel Edge SDKs already declare it.
  • @sentry/node no longer exports the type.
  • Migration docs updated.

Why

The type existed to share OpenTelemetry options across server runtimes, but the rest of those options (skipOpenTelemetrySetup, openTelemetryInstrumentations, openTelemetrySpanProcessors, validateOpenTelemetrySetup) are already gone. With a single option left, the shared base only added indirection.

Closes: #21118

Co-Authored-By: Opus 5 <noreply@anthropic.com>

@nicohrubec nicohrubec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

Comment thread MIGRATION.md Outdated
### `@sentry/node` / Server-side SDKs

- `SentryContextManager` is no longer exported. It is no longer needed now that Sentry does not set up OpenTelemetry by default.
- The `OpenTelemetryServerRuntimeOptions` type was removed. Its only remaining option, `enableOpenTelemetrySetup`, is part of the SDK-specific options types (e.g. `NodeOptions`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't update this yet I think, only after the next release

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, dropped it. Will add it back after the next release.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.35 kB +1.74% +518 B 🔺
@sentry/browser - with treeshaking flags 28.52 kB +1.75% +490 B 🔺
@sentry/browser (incl. Tracing) 48.61 kB +2.9% +1.37 kB 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.62 kB +2.86% +1.35 kB 🔺
@sentry/browser (incl. Tracing, Profiling) 53.46 kB +2.82% +1.47 kB 🔺
@sentry/browser (incl. Tracing, Replay) 88.04 kB +1.68% +1.45 kB 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.45 kB +1.91% +1.45 kB 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 92.77 kB +1.63% +1.48 kB 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 105.45 kB +1.45% +1.5 kB 🔺
@sentry/browser (incl. Feedback) 47.69 kB +1.18% +554 B 🔺
@sentry/browser (incl. sendFeedback) 35.18 kB +1.47% +508 B 🔺
@sentry/browser (incl. FeedbackAsync) 40.33 kB +1.41% +557 B 🔺
@sentry/browser (incl. Metrics) 31.43 kB +1.68% +517 B 🔺
@sentry/browser (incl. Logs) 31.66 kB +1.65% +511 B 🔺
@sentry/browser (incl. Metrics & Logs) 32.34 kB +1.66% +525 B 🔺
@sentry/react 32.14 kB +1.64% +517 B 🔺
@sentry/react (incl. Tracing) 50.82 kB +2.65% +1.31 kB 🔺
@sentry/vue 35.45 kB +1.5% +523 B 🔺
@sentry/vue (incl. Tracing) 50.59 kB +2.73% +1.34 kB 🔺
@sentry/svelte 30.38 kB +1.75% +522 B 🔺
CDN Bundle 31.61 kB -0.84% -265 B 🔽
CDN Bundle (incl. Tracing) 48.92 kB +2.9% +1.38 kB 🔺
CDN Bundle (incl. Logs, Metrics) 33.84 kB +1.3% +432 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 50.88 kB +3.96% +1.94 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 74.38 kB +2.24% +1.63 kB 🔺
CDN Bundle (incl. Tracing, Replay) 86.49 kB +1.54% +1.31 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.4 kB +2.2% +1.9 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 92.21 kB +1.32% +1.2 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.18 kB +2.03% +1.87 kB 🔺
CDN Bundle - uncompressed 93.95 kB -0.71% -669 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 146.92 kB +3.38% +4.8 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.42 kB +1.19% +1.18 kB 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.78 kB +4.58% +6.68 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.34 kB +2.42% +5.41 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.17 kB +1.84% +4.8 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.01 kB +2.52% +6.67 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.87 kB +1.75% +4.79 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.7 kB +2.39% +6.67 kB 🔺
@sentry/nextjs (client) 53.38 kB +2.49% +1.3 kB 🔺
@sentry/sveltekit (client) 49.03 kB +2.77% +1.32 kB 🔺
@sentry/core/server 65.6 kB +0.12% +75 B 🔺
@sentry/core/browser 51.92 kB +0.07% +36 B 🔺
@sentry/node 118.46 kB -1.48% -1.78 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.57 kB -1.34% -1.12 kB 🔽
@sentry/aws-serverless 91.94 kB -0.45% -413 B 🔽
@sentry/cloudflare (withSentry) - minified 214.7 kB -1.81% -3.94 kB 🔽
@sentry/cloudflare (withSentry) 530.23 kB -1.6% -8.62 kB 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.85 kB added added

View base workflow run

@nicohrubec

Copy link
Copy Markdown
Member

clean

@andreiborza
andreiborza marked this pull request as ready for review August 10, 2026 12:51
@andreiborza
andreiborza requested review from a team as code owners August 10, 2026 12:51
@andreiborza
andreiborza requested review from JPeer264 and mydea and removed request for a team August 10, 2026 12:51
@andreiborza
andreiborza merged commit 5003037 into develop Aug 10, 2026
529 of 533 checks passed
@andreiborza
andreiborza deleted the ab/remove-opentelemetry-server-runtime-options branch August 10, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove OpenTelemetryServerRuntimeOptions

2 participants