feat(opentelemetry): Remove setupEventContextTrace - #23226
Open
mydea wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4bf1290. Configure here.
| @@ -1,7 +1,5 @@ | |||
| export { getScopesFromContext } from './utils/contextData'; | |||
|
|
|||
| export { setupEventContextTrace } from './setupEventContextTrace'; | |||
There was a problem hiding this comment.
Public API removed without deprecation
High Severity
Flagged because of the PR Review Guidelines rule on breaking changes: setupEventContextTrace was a publicly exported @sentry/opentelemetry API and is removed here with no deprecation path. Downstream imports will fail, and MIGRATION.md also does not mention this removal.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 4bf1290. Configure here.
Contributor
size-limit report 📦
|
We no longer need this.
mydea
force-pushed
the
fn/remove-setupEventContextTrace
branch
from
August 10, 2026 12:40
4bf1290 to
453bfc7
Compare
mydea
marked this pull request as ready for review
August 10, 2026 13:15
mydea
requested review from
JPeer264 and
isaacs
and removed request for
a team
August 10, 2026 13:15
Comment on lines
98
to
103
| setupOtel(client); | ||
| } | ||
|
|
||
| setupEventContextTrace(client); | ||
|
|
||
| return client; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: The removal of setupEventContextTrace in the Node SDK is not automatically replaced. Users with enableOpenTelemetrySetup: true will lose OTel trace context unless they manually add otlpIntegration.
Severity: MEDIUM
Suggested Fix
Automatically add otlpIntegration to the default integrations in the Node SDK when the enableOpenTelemetrySetup option is set to true. This would restore the previous behavior where OpenTelemetry trace context is automatically captured without requiring manual configuration from the user. Alternatively, clearly document this breaking change and instruct users to add the integration manually.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/vercel-edge/src/sdk.ts#L98-L103
Potential issue: The Node SDK previously used `setupEventContextTrace` to automatically
link Sentry events with active OpenTelemetry (OTel) spans when
`enableOpenTelemetrySetup` was true. This function has been removed. The replacement,
`otlpIntegration`, is not enabled by default. Consequently, users who enable OTel setup
will no longer have trace context from active OTel spans automatically associated with
their Sentry events. This is a breaking change that can lead to broken or incomplete
traces for users relying on the previous automatic OTel span linkage, unless they
manually add `otlpIntegration()` to their Sentry configuration.
Also affects:
packages/node/src/sdk/index.ts:230~235
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need this after #23225, as this should now pick up the correct span also for otel.