feat(core): Use getActiveSpan instead of _getSpanFromScope for logs & metrics - #23223
Open
mydea wants to merge 1 commit into
Open
feat(core): Use getActiveSpan instead of _getSpanFromScope for logs & metrics#23223mydea wants to merge 1 commit into
getActiveSpan instead of _getSpanFromScope for logs & metrics#23223mydea wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3b4dd9c. Configure here.
| } | ||
|
|
||
| const span = _getSpanForScope(currentScope); | ||
| const span = getActiveSpan(currentScope); |
There was a problem hiding this comment.
Feat PR lacks integration tests
Low Severity
Flagged because it was mentioned in the PR review rules file: feat PRs need at least one integration or E2E test. This change switches logs and metrics span lookup to getActiveSpan, which mainly affects Node/OTEL correlation, but the PR adds no test covering that. Existing metrics suites already emit inside startSpan without asserting span_id / sentry.trace.parent_span_id.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3b4dd9c. Configure here.
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
August 10, 2026 12:21
logaretm
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this API instead of a stack-specific one.