chore(browser)!: Remove legacy profiling option profilesSampleRate - #23220
Open
s1gr1d wants to merge 1 commit into
Open
chore(browser)!: Remove legacy profiling option profilesSampleRate#23220s1gr1d wants to merge 1 commit into
profilesSampleRate#23220s1gr1d wants to merge 1 commit into
Conversation
s1gr1d
requested review from
logaretm and
msonnb
and removed request for
a team
August 10, 2026 10:43
Contributor
size-limit report 📦
|
s1gr1d
commented
Aug 10, 2026
Comment on lines
-62
to
-64
| // fixme: figure out why profiler_id is set on feedback and not on pageload transaction | ||
| // todo: rename to `profiler_id` | ||
| expect(feedbackEvent.contexts?.profile?.profile_id).toMatch(/^[a-f\d]{32}$/); |
Member
Author
There was a problem hiding this comment.
@andreiborza As you added this comment: this can be removed now, right? I added an additional check so we know it's on both the feedback event and the pageload.
msonnb
approved these changes
Aug 10, 2026
Member
There was a problem hiding this comment.
iirc @nicohrubec mentioned that we should add new breaking changes to docs/migration/v11-end-state.md instead of this one
Member
There was a problem hiding this comment.
jep, so MIGRATION.md should stay up to date with our latest release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser UI profiling now uses only
profileSessionSampleRateandprofileLifecycle. This PR removes all code that belonged to the previous option.Removed tests and logic for legacy option.
Part of #23021