feat(core): Streamline tracing channel bindings - #23218
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f783616. Configure here.
| return withActiveSpan(span, () => { | ||
| return asyncLocalStorage.getStore(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Missing tests for streamlined binding
Medium Severity
This feat PR moves ignored-span handling into getStoreWithActiveSpan but deletes the unit tests that covered that behavior, and adds no integration or E2E coverage for the new withActiveSpan-based binding path. That leaves ignoreSpans parenting over tracing channels untested and risks silent regressions.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit f783616. Configure here.
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
August 10, 2026 10:27
mydea
requested review from
JPeer264,
andreiborza and
logaretm
and removed request for
a team
August 10, 2026 10:27
andreiborza
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was more complicated than necessary, turns out - we can just use
withActiveSpanhere instead.