chore(node)!: Remove legacy profiling options (profilesSampleRate and profilesSampler) - #23216
Merged
Merged
Conversation
…d `profilesSampler`)
s1gr1d
requested review from
JPeer264 and
mydea
and removed request for
a team
August 10, 2026 09:38
profilesSampleRate and profilesSampler)profilesSampleRate and profilesSampler)
Contributor
size-limit report 📦
|
s1gr1d
enabled auto-merge (squash)
August 10, 2026 12:43
s1gr1d
disabled auto-merge
August 10, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node profiling now uses only
profileSessionSampleRateandprofileLifecycle. This PR removes all code that belonged to the previous options.Updated tests (removed tests for legacy options) and added E2E assertions (was only checking the build previously).
Browser profiling will be updated in a follow-up PR.
Closes of #23021