feat(server-utils): Add db span op for generic-pool acquire spans - #23213
Merged
Conversation
`generic-pool.acquire` spans carried an `auto.db.generic_pool` origin but no op, so they were unclassified. An acquire isn't a query, but the pool overwhelmingly backs database connection pools (knex, sequelize, mongoose), so the generic `db` category groups it with the work it gates. Ref JS-3318 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
August 10, 2026 09:45
msonnb
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
August 10, 2026 09:45
andreiborza
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generic-pool.acquirespans carried anauto.db.generic_poolorigin but no op. They now have the genericdbop (rather thandb.query, since pool acquisition is no query)part of #23138