Skip to content

test(cloudflare): Cover enableDedupe option - #23210

Merged
JPeer264 merged 2 commits into
developfrom
jp/cloudflare-dedupe-tests
Aug 10, 2026
Merged

test(cloudflare): Cover enableDedupe option#23210
JPeer264 merged 2 commits into
developfrom
jp/cloudflare-dedupe-tests

Conversation

@JPeer264

Copy link
Copy Markdown
Member

Adds tests to check if enableDedupes is really disabled for workflows

original trigger: #23151 (comment)

Adds unit tests asserting the Dedupe integration is installed by default and
omitted when `enableDedupe: false`, plus an integration test proving identical
exceptions captured within a single workflow run are all delivered.

The existing workflow retry tests did not cover this: Workflows replay `run`
from the top on each retry, so every attempt gets a fresh client and fresh
dedupe state. Only duplicates within one invocation can be collapsed, so the
new fixture captures the same error twice from the same line.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JPeer264 JPeer264 self-assigned this Aug 10, 2026
@JPeer264
JPeer264 requested a review from a team as a code owner August 10, 2026 09:11
@JPeer264
JPeer264 requested review from andreiborza and mydea and removed request for a team August 10, 2026 09:11
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.35 kB - -
@sentry/browser - with treeshaking flags 28.52 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.85 kB - -
@sentry/browser (incl. Tracing) 48.63 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.64 kB - -
@sentry/browser (incl. Tracing, Profiling) 53.48 kB - -
@sentry/browser (incl. Tracing, Replay) 88.06 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.47 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.78 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.47 kB - -
@sentry/browser (incl. Feedback) 47.69 kB - -
@sentry/browser (incl. sendFeedback) 35.18 kB - -
@sentry/browser (incl. FeedbackAsync) 40.33 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.66 kB - -
@sentry/browser (incl. Metrics & Logs) 32.34 kB - -
@sentry/react 32.14 kB - -
@sentry/react (incl. Tracing) 50.83 kB - -
@sentry/vue 35.45 kB - -
@sentry/vue (incl. Tracing) 50.6 kB - -
@sentry/svelte 30.38 kB - -
CDN Bundle 32.32 kB - -
CDN Bundle (incl. Tracing) 49.6 kB - -
CDN Bundle (incl. Logs, Metrics) 33.84 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.9 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.38 kB - -
CDN Bundle (incl. Tracing, Replay) 87.13 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.41 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.94 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.19 kB - -
CDN Bundle - uncompressed 95.83 kB - -
CDN Bundle (incl. Tracing) - uncompressed 148.84 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.42 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.82 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.34 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.09 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.06 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.79 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.74 kB - -
@sentry/nextjs (client) 53.41 kB - -
@sentry/sveltekit (client) 49.04 kB - -
@sentry/core/server 65.7 kB - -
@sentry/core/browser 52.02 kB - -
@sentry/node 119.23 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 83.23 kB - -
@sentry/aws-serverless 92.51 kB -0.01% -1 B 🔽
@sentry/cloudflare (withSentry) - minified 214.91 kB - -
@sentry/cloudflare (withSentry) 530.62 kB - -

View base workflow run

Comment on lines +35 to +37
for (let i = 0; i < 2; i++) {
Sentry.captureException(new Error('Manual capture'));
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (let i = 0; i < 2; i++) {
Sentry.captureException(new Error('Manual capture'));
}
Sentry.captureException(new Error('Manual capture'));
Sentry.captureException(new Error('Manual capture'));

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@JPeer264
JPeer264 enabled auto-merge (squash) August 10, 2026 09:25
@JPeer264
JPeer264 merged commit c5452a6 into develop Aug 10, 2026
272 checks passed
@JPeer264
JPeer264 deleted the jp/cloudflare-dedupe-tests branch August 10, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants