ref(node): Stop inferring op for spans - #23195
Merged
Merged
Conversation
mydea
force-pushed
the
fn/fully-remove-inferral
branch
from
August 10, 2026 07:58
9691c4f to
a595843
Compare
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/fully-remove-inferral
branch
from
August 10, 2026 08:29
a595843 to
935dec1
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 935dec1. Configure here.
| * On the OTel SDK provider this happens in the `SentrySpanProcessor`/`SentrySpanExporter` while | ||
| * converting `ReadableSpan`s to Sentry payloads (via `parseSpanDescription` + `mapStatus`). | ||
| * `SentryTracerProvider` creates native Sentry spans directly and never goes through that pipeline, | ||
| * so the same inference has to run here instead — once at span start, and again at span end |
There was a problem hiding this comment.
Public op-inference API removed
Medium Severity
This violates the Breaking Changes review rule: applyOtelSpanData is a public @sentry/opentelemetry export that previously inferred sentry.op, and calls without finalizeStatus are now a no-op. backfillStreamedSpanDataFromOtel was also removed from the public export surface with no deprecation notice, which can break custom OTel setups that relied on that inference.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 935dec1. Configure here.
mydea
force-pushed
the
fn/fully-remove-inferral
branch
from
August 10, 2026 08:34
935dec1 to
f43eab0
Compare
mydea
marked this pull request as ready for review
August 10, 2026 08:58
mydea
requested review from
JPeer264,
andreiborza,
chargome and
s1gr1d
and removed request for
a team
August 10, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop inferring span ops for node spans. Instead, ensure we actually set the op at span creation time already.
This also removes an otel double instrumentation test as we no longer need this.