ref(node): Stop inferring url-attributes for spans - #23187
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2716363. Configure here.
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/span-attribute-inferral
branch
from
August 10, 2026 07:41
2716363 to
da1d103
Compare
mydea
marked this pull request as ready for review
August 10, 2026 07:41
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
August 10, 2026 07:41
andreiborza
approved these changes
Aug 10, 2026
JPeer264
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only thing that we still used data-inferral for in spans, and we should already have replaced this usage in previous PRs here I believe.
Also removing the origin=manual fallback which should also no longer be needed I believe.