fix(bundler-plugin-tests): Normalize prerelease versions in telemetry snapshots - #23158
Merged
nicohrubec merged 1 commit intoAug 7, 2026
Merged
Conversation
… snapshots Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
andreiborza
approved these changes
Aug 7, 2026
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 8
telemetry.test.tsbundler fixtures failed on therelease/11.0.0-alpha.0branch because the version normalizer infixtures/utils.tsonly matched plainX.Y.Zsemver.The
releaseandversionnormalization regexes used the character class[\d.]+, which stops at the first non-digit/non-dot character. On a prerelease version like11.0.0-alpha.0, the-alpha.0suffix is left unmatched, so the literal version leaked into the telemetry payload instead of being replaced with thePLUGIN_VERSION/SDK_VERSIONplaceholders the inline snapshots expect — mismatching all 8 fixtures.This never surfaced on regular PRs because
developalways carries a plain semver; it only triggers on a release branch, and would break the check on every alpha/beta/rc.Both regexes now accept an optional prerelease suffix (
(?:-[\w.]+)?). The committed inline snapshots already contain the placeholders, so no snapshots need regenerating.Root cause: version normalization regex did not account for prerelease identifiers.