ref(server-utils)!: Consolidate AI integration option types into shared GenAiOptions - #23103
Draft
nicohrubec wants to merge 3 commits into
Draft
ref(server-utils)!: Consolidate AI integration option types into shared GenAiOptions#23103nicohrubec wants to merge 3 commits into
GenAiOptions#23103nicohrubec wants to merge 3 commits into
Conversation
…ed `GenAiOptions`
Every AI integration declared its own structurally-identical options interface
(`OpenAiOptions`, `AnthropicAiOptions`, `GoogleGenAIOptions`, `LangChainOptions`,
`LangGraphOptions`, `WorkersAiOptions`, `VercelAiOptions`, and the internal
`VercelAiChannelOptions`) — all just `{ recordInputs?: boolean; recordOutputs?: boolean }`.
Rename the existing internal `AIRecordingOptions` to `GenAiOptions`, give it crisp
provider-agnostic JSDoc, export it from the package index, and use it everywhere the
per-integration types were used. Deletes all the duplicated interfaces.
The vercel-edge integration keeps its own (intentionally field-less) local options
type, since that entrypoint cannot honor input/output recording.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ebbf070. Configure here.
Contributor
size-limit report 📦
|
Shortening the option type names collapsed these multi-line signatures/imports under the print width, so oxfmt reformats them onto a single line. Apply the formatting so the CI format check passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every AI integration declared its own structurally-identical options interface (
OpenAiOptions,AnthropicAiOptions,GoogleGenAIOptions,LangChainOptions,LangGraphOptions,WorkersAiOptions,VercelAiOptions, plus the internalVercelAiChannelOptions) — all just{ recordInputs?: boolean; recordOutputs?: boolean }.This renames the existing internal
AIRecordingOptionstoGenAiOptions, gives it provider-agnostic JSDoc, exports it from the@sentry/server-utilsindex, and uses it everywhere the per-integration types were used — deleting all the duplicated interfaces.Decisions:
GenAiOptionsdirectly.vercel-edgeintegration keeps its own local, intentionally field-less options type, since that entrypoint only post-processes spans the AI SDK already emitted and cannot decide whether inputs/outputs are recorded.resolveAIRecordingOptionsfunction name is unchanged.