fix(browser)!: Use snake_case consistently for ops - #23100
Open
msonnb wants to merge 2 commits into
Open
Conversation
Contributor
size-limit report 📦
|
The `pageload-browser-spans` integration test builds the expected op
dynamically (`browser.${eventDesc}`), so the earlier literal search
missed it when the navigation-timing ops were switched to snake_case.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
msonnb
marked this pull request as ready for review
August 6, 2026 15:00
logaretm
reviewed
Aug 6, 2026
logaretm
left a comment
Member
There was a problem hiding this comment.
q: Can those attributes be imported from sentry-conventions/op?
I didn't want to leave a comment on every single one.
| startAndEndSpan(parent, startTime, startTime + duration, { | ||
| name: 'Main UI thread blocked', | ||
| op: 'ui.long-task', | ||
| op: 'ui.long_task', |
Member
There was a problem hiding this comment.
Can those attributes be imported from sentry-conventions/op?
| startAndEndSpan(parent, startTime, startTime + duration, { | ||
| name: 'Main UI thread blocked', | ||
| op: 'ui.long-animation-frame', | ||
| op: 'ui.long_animation_frame', |
Member
Author
@logaretm not yet since they're not released yet. i would do the breaking change now, then switch to the imported constants once they're released and we bumped the package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some
browser.*andui.*ops used inconsistent casing, this aligns them to snake_case as set by conventions.ui.long-taskui.long_taskui.long-animation-frameui.long_animation_framebrowser.unloadEventbrowser.unload_eventbrowser.domContentLoadedEventbrowser.dom_content_loaded_eventbrowser.loadEventbrowser.load_eventbrowser.TLS/SSLbrowser.tls_sslbrowser.DNSbrowser.dnsresouce.script(typo)resource.script