test(react-router)!: Add orchestrion based cloudflare app - #23063
Open
chargome wants to merge 1 commit into
Open
test(react-router)!: Add orchestrion based cloudflare app#23063chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5fd138c. Configure here.
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
August 6, 2026 11:41
chargome
requested review from
JPeer264,
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team and
s1gr1d
August 6, 2026 11:41
Member
|
If I'm not mistaken this PR could be obsolete with #23075. The test wouldn't harm though |
chargome
marked this pull request as draft
August 7, 2026 10:34
chargome
force-pushed
the
feat/react-router-cloudflare-orchestrion
branch
from
August 7, 2026 10:50
a37f65b to
84189bc
Compare
Covers React Router on workerd: orchestrion's build-time transform injects the `diagnostics_channel` publishers and the subscriber registration into the worker bundle, and `withSentry` picks them up, so a real mysql query emits `db` spans with no runtime module hook (which workerd can't provide). Follows Cloudflare's own React Router scaffold — `@cloudflare/vite-plugin`, `workers/app.ts`, `nodejs_compat`. The nested query covers async-context restoration across mysql's socket callback. Ref: #22632 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
feat/react-router-cloudflare-orchestrion
branch
from
August 7, 2026 12:52
84189bc to
1f05286
Compare
chargome
marked this pull request as ready for review
August 7, 2026 15:25
Member
Author
|
@JPeer264 updated the pr so only the test remains |
JPeer264
approved these changes
Aug 7, 2026
nicohrubec
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
react-router-8-cloudflaree2e app.ref: #22632