fix(repo): fix tsconfig diagnostics surfaced by tsgolint 7#22560
Merged
Conversation
logaretm
marked this pull request as ready for review
July 23, 2026 15:58
logaretm
requested review from
andreiborza,
chargome,
isaacs and
nicohrubec
and removed request for
a team
July 23, 2026 15:58
nicohrubec
approved these changes
Jul 23, 2026
logaretm
marked this pull request as draft
July 23, 2026 16:22
logaretm
marked this pull request as ready for review
July 23, 2026 16:23
With the SUPPRESS_PROGRAM_DIAGNOSTICS workaround gone, tsgolint validates each package's tsconfig. Adds the missing `rootDir` to effect (it sets `outDir` without one) and widens profiling-node's test `rootDir` to the package root so `test/**` and `vite.config.ts` are covered. Also drops ember's `baseUrl` (removed in TS7) and makes its `paths` values relative.
logaretm
force-pushed
the
awad/ts7-tsconfig-fixes
branch
from
July 23, 2026 16:49
838479d to
07876d0
Compare
logaretm
marked this pull request as draft
July 23, 2026 16:51
logaretm
marked this pull request as ready for review
July 23, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the per-package tsconfig problems tsgolint 7 surfaces once program diagnostics are no longer suppressed.
Those weren't caught because the build process doesn't use TS 7 for these projects. This allows them to be linted with unsuppressed tslint in a later PR.