feat(core): Ensure url, http.query and http.fragment are directly added#22547
Open
mydea wants to merge 3 commits into
Open
feat(core): Ensure url, http.query and http.fragment are directly added#22547mydea wants to merge 3 commits into
url, http.query and http.fragment are directly added#22547mydea wants to merge 3 commits into
Conversation
url, http.query and http.fragment are directly added
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6bc9b0. Configure here.
| } | ||
| if (parsedUrl.hash) { | ||
| attributes['http.fragment'] = parsedUrl.hash; | ||
| attributes[HTTP_FRAGMENT] = parsedUrl.hash.slice(1) || undefined; |
There was a problem hiding this comment.
Split HTTP query fragment formats
Medium Severity
This commit normalizes http.query and http.fragment by stripping leading ? and # in core fetch, HTTP breadcrumbs, URL span helpers, and Node server spans, but browser XHR and Node undici fetch breadcrumbs still emit the raw URL.search / URL.hash values with those prefixes. The same app can therefore report different query and fragment shapes on http.client spans and HTTP breadcrumbs depending on the API used.
Reviewed by Cursor Bugbot for commit d6bc9b0. Configure here.
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
July 23, 2026 13:28
mydea
requested review from
andreiborza,
isaacs,
logaretm and
msonnb
and removed request for
a team
July 23, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We rely on this in many tests, but only set this in span inferral often, so it depends on OTEL stuff.