feat(v10/cloudflare): Auto-instrument WorkerEntrypoint classes#22543
Draft
andreiborza wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ef96f7a. Configure here.
| const classId = classDecl.id; | ||
| const kind = classId ? ctx.classWrappers.get(classId.name) : undefined; | ||
| // Inline export: the exported name and the local class name are the same. | ||
| const kind = classId ? resolveWrapperKind(classId.name, classId.name, state) : undefined; |
There was a problem hiding this comment.
Exported base breaks subclass wrap
High Severity
Structural detection wraps every exported class in a WorkerEntrypoint chain, but the rewrite only renames the declaration and rebinds that name to a withSentry Proxy. Same-file subclasses still extends the old name, so they inherit the Proxy. instrumentWorkerEntrypoint does not forward newTarget, so subclass methods are lost and construction double-instruments.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit ef96f7a. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #22493