feat(v10/cloudflare): Auto-instrument Durable Object classes#22541
Draft
andreiborza wants to merge 1 commit into
Draft
feat(v10/cloudflare): Auto-instrument Durable Object classes#22541andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2de5e1c. Configure here.
| 'declaration found in the worker entry (re-exports from other modules cannot be wrapped ' + | ||
| 'automatically). Wrap them manually with the matching `instrument*WithSentry` helper.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
False warning on re-exported DO
Medium Severity
Build-time missing-class detection treats any wrangler-configured Durable Object not listed in wrappedClasses as uninstrumented. When the entry only re-exports a class that was already wrapped with instrumentDurableObjectWithSentry in another module (import { Counter } from './counter' then export { Counter }, or export { Counter } from './counter'), the transform correctly skips wrapping but never records the class as wrapped, so Vite still emits a “Could not auto-instrument … Wrap them manually” warning for a already-instrumented export.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 2de5e1c. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #22437