feat(v10/cloudflare): Read wrangler config and resolve the Sentry options module#22538
Draft
andreiborza wants to merge 1 commit into
Draft
feat(v10/cloudflare): Read wrangler config and resolve the Sentry options module#22538andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
…ions module Backport of: #22421
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e7010a7. Configure here.
| optionsFn: OPTIONS_IMPORT_IDENTIFIER, | ||
| importStmt: `import ${OPTIONS_IMPORT_IDENTIFIER} from '${relativePath}';\n`, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Unused instrument file helpers
Medium Severity
ENV_FALLBACK_OPTIONS_FN, resolveInstrumentFile, and buildOptionsImport are never imported by production or test code, and resolveWranglerConfig is not wired into sentryCloudflareVitePlugin. Because rollup only bundles from entrypoints, these modules also never ship in the published Vite plugin bundle.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e7010a7. Configure here.
| config: { main: raw.main, durableObjects }, | ||
| configDir: dirname(raw.configPath ?? configPath), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Feat PR lacks integration tests
Medium Severity
This is a feat PR but only adds unit tests. Per the PR review guidelines, feat PRs need at least one integration or E2E test; none cover wrangler-config resolution, instrument-file lookup, or defineCloudflareOptions end-to-end with the Vite plugin.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit e7010a7. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #22421