feat: Add http.route attribute to http.server spans with parameterized routes#22534
Merged
Conversation
Lms24
marked this pull request as ready for review
July 23, 2026 11:52
Lms24
requested review from
chargome and
nicohrubec
and removed request for
a team
July 23, 2026 11:52
nicohrubec
approved these changes
Jul 23, 2026
Lms24
force-pushed
the
lms/feat-add-http-route-attribute
branch
from
July 23, 2026 13:43
85949f1 to
ae9c5fa
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae9c5fa. Configure here.
Lms24
enabled auto-merge (squash)
July 23, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
http.routeattribute that was missing on a fewhttp.serverspans when we found a parameterized route. Mostly this concernedhttp.serverspans we emit manually from frameworks (as opposed to Node http integration) or spans we enhance from OTel-based framework telemetry (Next/Sveltekit).I decided against also adding
url.template, since this attribute is more used on the client-side. Will open a PR in conventions to disambiguate these attributes.For the node:http spans, we already set the attribute in the higher level integrations (express, koa, etc), so there was nothing to add there.
closes #22417