feat: Remove support for initialising via --require#22513
Open
timfish wants to merge 1 commit into
Open
Conversation
Contributor
size-limit report 📦
|
timfish
marked this pull request as ready for review
July 22, 2026 17:38
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 143a4cc. Configure here.
| const joinedArgs = execArgv.join(' '); | ||
| const importPaths = Array.from(joinedArgs.matchAll(/--import[ =](\S+)/g)).map(e => resolve(cwd, e[1] || '')); | ||
| const requirePaths = Array.from(joinedArgs.matchAll(/--require[ =](\S+)/g)).map(e => resolve(cwd, e[1] || '')); | ||
| const requirePaths = Array.from(joinedArgs.matchAll(/(?:--require|-r)[ =](\S+)/g)).map(e => resolve(cwd, e[1] || '')); |
There was a problem hiding this comment.
Require warning misses package preloads
Medium Severity
The new --require migration warning relies on getEntryPointType(), but parseProcessPaths resolves preload targets with path.resolve(cwd, ...). Package specifiers like @sentry/node/init never match real stack filenames under node_modules, so the documented no-code --require entry points silently skip the warning.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 143a4cc. Configure here.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialising via
--requireresults in the SDK being loaded and initialised in Node's ESM loader thread 🤯This causes numerous issues:
require(esm)does not work correctly - feat: Convert code to CJS apm-js-collab/tracing-hooks#51The last straw way failing to
require(esm). This stops us from using any import/require chain that results in CJS requiring ESM. It's part of the reason/server-utils/src/orchestrion/runtime/register.tsneeded to do lazy loading.Since it's so problematic and
--importsupports loading ESM or CJS everywhere, we should remove support and warn users!