test(nextjs): Add zero-infra orchestrion instrumentations to e2e app#22507
Draft
chargome wants to merge 2 commits into
Draft
test(nextjs): Add zero-infra orchestrion instrumentations to e2e app#22507chargome wants to merge 2 commits into
chargome wants to merge 2 commits into
Conversation
Add e2e coverage for generic-pool, lru-memoizer, dataloader and knex orchestrion instrumentations in the nextjs-16-orchestrion app. None require new infra: knex reuses the existing Postgres container, the rest are pure-JS. dataloader and knex are opt-in integrations, so they are added explicitly in the server config. Fixes #22504 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
buglitzer run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d0e11c. Configure here.
…tore The load callback was fired inside the startSpan callback, so the memoized callback could see the check span through normal async context propagation — the assertion passed even when orchestrion's context restore was broken. Fire the load after startSpan returns (outside the span's active context) so only the restore can make the callback observe the span, matching the node lru-memoizer integration test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e coverage for
generic-pool,lru-memoizer,dataloaderandknexorchestrion instrumentations in thenextjs-16-orchestrionapp. No new infra —knexreuses the existing Postgres container, the rest are pure-JS.dataloaderandknexare opt-in, so they're added explicitly in the server config.Closes #22504