feat(deno): add firebase integration#22466
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 20:17
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-firebase
branch
from
July 21, 2026 20:55
4a7b537 to
4fa1a42
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-aws
branch
from
July 21, 2026 20:55
78c6cec to
38210fe
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-firebase
branch
from
July 21, 2026 21:31
4fa1a42 to
932c59a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-aws
branch
from
July 21, 2026 21:31
38210fe to
5ef8ac5
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-firebase
branch
from
July 21, 2026 21:43
932c59a to
2c24656
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-aws
branch
from
July 21, 2026 21:43
5ef8ac5 to
be31ed1
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2c24656. Configure here.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-firebase
branch
from
July 22, 2026 00:51
2c24656 to
1f07c42
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-aws
branch
from
July 22, 2026 00:51
be31ed1 to
587cd7b
Compare
JPeer264
approved these changes
Jul 22, 2026
nicohrubec
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-firebase
branch
from
July 22, 2026 14:42
1f07c42 to
7afd3e8
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-aws
branch
from
July 22, 2026 14:42
587cd7b to
997d812
Compare
Comment on lines
90
to
96
| amqplibChannelIntegration(), | ||
| awsChannelIntegration(), | ||
| expressChannelIntegration(), | ||
| firebaseChannelIntegration(), | ||
| genericPoolChannelIntegration(), | ||
| hapiChannelIntegration(), | ||
| kafkajsChannelIntegration(), |
Contributor
There was a problem hiding this comment.
Bug: Firebase instrumentation will silently fail in bundler-only environments (e.g., Cloudflare Workers) because firebaseChannelIntegration is missing from CHANNEL_INTEGRATION_DEFINITIONS.
Severity: MEDIUM
Suggested Fix
Add firebaseChannelIntegration to the CHANNEL_INTEGRATION_DEFINITIONS map in config/index.ts. This will allow the bundler's subscribe-injection transform to correctly find and inject the Firebase instrumentation for environments like Cloudflare Workers. Consider adding other missing integrations like awsChannelIntegration and mongodbChannelIntegration as well.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/deno/src/sdk.ts#L90-L96
Potential issue: The `firebaseChannelIntegration` is not included in the
`CHANNEL_INTEGRATION_DEFINITIONS` map, which is used by bundler-only SDKs like
Cloudflare Workers when `injectChannelSubscribers: true` is set. The bundler's injection
transform uses `subscriberExportForModule` to look up integrations in this map. Because
the Firebase integration is missing, the lookup returns `undefined`, and the
instrumentation injection is silently skipped. This results in a lack of Firebase
instrumentation in environments like Cloudflare Workers, without any error or warning.
The same issue exists for other integrations like AWS and MongoDB.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.