Skip to content

feat(core): Add url.full attribute to core fetch instrumentation#22415

Merged
Lms24 merged 3 commits into
developfrom
lms/ref-core-url.full
Jul 21, 2026
Merged

feat(core): Add url.full attribute to core fetch instrumentation#22415
Lms24 merged 3 commits into
developfrom
lms/ref-core-url.full

Conversation

@Lms24

@Lms24 Lms24 commented Jul 21, 2026 •
edited by nicohrubec
Loading

Copy link
Copy Markdown
Member

The attribute was missing in the core fetch instrumentation, causing vercel-edge and cloudflare fetch spans to not include it. For browser, it was already added on top of the core instrumentation.

Further changes:

  • swap out hard-coded url.full attributes for constant from conventions
  • also replace some other, related hard-coded attribute names with conventions constatns
  • deprecate and replace SEMANTIC_ATTRIBUTE_URL_FULL with conventions constant

closes #22416

cursor[bot]
cursor Bot reviewed Jul 21, 2026
View reviewed changes
Comment thread packages/core/src/fetch.ts
@Lms24 Lms24 self-assigned this Jul 21, 2026
@Lms24
Lms24 force-pushed the lms/ref-core-url.full branch from 0726f56 to 50f2d36 Compare July 21, 2026 11:52
@Lms24

Lms24 commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

bugbot review

cursor[bot]
cursor Bot reviewed Jul 21, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9861918. Configure here.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.76 kB +0.04% +11 B 🔺
@sentry/browser - with treeshaking flags 26.2 kB +0.05% +12 B 🔺
@sentry/browser (incl. Tracing) 46.57 kB +0.02% +7 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.38 kB +0.03% +10 B 🔺
@sentry/browser (incl. Tracing, Profiling) 51.38 kB +0.04% +16 B 🔺
@sentry/browser (incl. Tracing, Replay) 85.82 kB -0.02% -13 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.45 kB -0.02% -12 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 90.54 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 103.2 kB -0.01% -7 B 🔽
@sentry/browser (incl. Feedback) 44.95 kB +0.03% +12 B 🔺
@sentry/browser (incl. sendFeedback) 32.56 kB +0.03% +7 B 🔺
@sentry/browser (incl. FeedbackAsync) 37.69 kB -0.01% -2 B 🔽
@sentry/browser (incl. Metrics) 28.84 kB +0.02% +5 B 🔺
@sentry/browser (incl. Logs) 29.06 kB +0.03% +8 B 🔺
@sentry/browser (incl. Metrics & Logs) 29.76 kB +0.03% +7 B 🔺
@sentry/react 29.55 kB +0.03% +8 B 🔺
@sentry/react (incl. Tracing) 48.85 kB +0.03% +11 B 🔺
@sentry/vue 33.18 kB +0.03% +8 B 🔺
@sentry/vue (incl. Tracing) 48.55 kB +0.05% +21 B 🔺
@sentry/svelte 27.78 kB - -
CDN Bundle 30.16 kB +0.05% +13 B 🔺
CDN Bundle (incl. Tracing) 48.54 kB +0.03% +14 B 🔺
CDN Bundle (incl. Logs, Metrics) 31.73 kB -0.01% -2 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 49.84 kB +0.02% +8 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 71 kB +0.03% +18 B 🔺
CDN Bundle (incl. Tracing, Replay) 86.04 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.36 kB +0.02% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 91.86 kB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.11 kB -0.01% -9 B 🔽
CDN Bundle - uncompressed 89.89 kB +0.02% +14 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 146.72 kB -0.01% -9 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.6 kB +0.02% +14 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 150.7 kB -0.01% -9 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 219.36 kB +0.01% +14 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.96 kB -0.01% -9 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 269.92 kB -0.01% -9 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.66 kB -0.01% -9 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 283.61 kB -0.01% -9 B 🔽
@sentry/nextjs (client) 51.37 kB +0.02% +7 B 🔺
@sentry/sveltekit (client) 46.98 kB -0.01% -4 B 🔽
@sentry/core/server 80.28 kB +0.04% +28 B 🔺
@sentry/core/browser 66.7 kB +0.01% +2 B 🔺
@sentry/node-core 63.21 kB - -
@sentry/node 125.73 kB -0.03% -33 B 🔽
@sentry/node (incl. diagnostics channel injection) 151.22 kB +0.02% +24 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 70.03 kB -0.01% -2 B 🔽
@sentry/node/light 51.33 kB +0.04% +16 B 🔺
@sentry/node - without tracing 74.91 kB -0.01% -5 B 🔽
@sentry/aws-serverless 84.16 kB +0.02% +13 B 🔺
@sentry/cloudflare (withSentry) - minified 197.7 kB +0.02% +37 B 🔺
@sentry/cloudflare (withSentry) 486.64 kB +0.01% +28 B 🔺

View base workflow run

@Lms24
Lms24 marked this pull request as ready for review July 21, 2026 14:34
@Lms24
Lms24 requested review from a team as code owners July 21, 2026 14:34
@Lms24
Lms24 requested review from JPeer264, chargome, isaacs, logaretm, msonnb and nicohrubec and removed request for a team July 21, 2026 14:34
@Lms24
Lms24 merged commit c33e056 into develop Jul 21, 2026
314 of 315 checks passed
@Lms24
Lms24 deleted the lms/ref-core-url.full branch July 21, 2026 14:43
@Lms24 Lms24 mentioned this pull request Jul 21, 2026
Merged
Lms24 added a commit that referenced this pull request Jul 21, 2026
@Lms24
feat(v10/core): Add url.full attribute to core fetch instrumentation (
86d017f 
#22436)

backport of #22415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@nicohrubec nicohrubec nicohrubec approved these changes
@chargome chargome Awaiting requested review from chargome chargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@isaacs isaacs Awaiting requested review from isaacs isaacs is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@JPeer264 JPeer264 Awaiting requested review from JPeer264 JPeer264 is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@logaretm logaretm Awaiting requested review from logaretm logaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@msonnb msonnb Awaiting requested review from msonnb msonnb is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees

@Lms24 Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure SDK emits url.full attribute on http.client spans

2 participants

@Lms24 @nicohrubec