fix(tanstackstart-react): Drop server transactions for tunnel route requests#21769
Open
logaretm wants to merge 3 commits into
Open
fix(tanstackstart-react): Drop server transactions for tunnel route requests#21769logaretm wants to merge 3 commits into
logaretm wants to merge 3 commits into
Conversation
mydea
reviewed
Jun 25, 2026
| return { | ||
| handlers: { | ||
| POST: async ({ request }) => { | ||
| const activeSpan = getActiveSpan(); |
Member
There was a problem hiding this comment.
any way to maybe solve this via suppressTracing instead? 🤔
Member
Author
There was a problem hiding this comment.
The span would be created outside of this callback so it wouldn't work
nicohrubec
reviewed
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server SDK was turning every incoming tunnel route request into an
http.servertransaction. This drops tunnel traffic for both the static and streamed (traceLifecycle: 'stream') span lifecycles.closes #21555