ref(node): Remove unusued sql-common helper and @opentelemetry/core dep#21688
Merged
Conversation
… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.
@opentelemetry/coredep@opentelemetry/core dep
nicohrubec
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored
addSqlCommenterCommenthelper (from@opentelemetry/sql-common) was never wired into any instrumentation. Thepgintegration explicitly dropped theaddSqlCommenterCommentToQueriesoption in #21583, leaving it dead code whose only consumer is its own unit test.It was also the sole user of
W3CTraceContextPropagator, so we can drop the direct@opentelemetry/coredependency.