Skip to content

test(node): Update mysql tests for better coverage and correctness#21684

Open
mydea wants to merge 7 commits into
developfrom
fn/fix-mysql-tests
Open

test(node): Update mysql tests for better coverage and correctness#21684
mydea wants to merge 7 commits into
developfrom
fn/fix-mysql-tests

Conversation

@mydea

@mydea mydea commented Jun 22, 2026

Copy link
Copy Markdown
Member

This updates the node-integration-tests for mysql package for better test coverage (in preparation of #21568), as well as also fixing some holes in the tests:

  • Previously, we did not have any MySQL server, which lead to some weird quirks, e.g. spans being marked as failed because no server is found etc. This kind of skewed the results. This PR introduces a minimal, node-written MySQL server that only replies with OK/ERROR, just enough for our tests.
  • Add tests for connection pooling
  • Add tests for streamed query errors
  • Add tests for context stability in streamed queries

@mydea mydea self-assigned this Jun 22, 2026
@mydea mydea requested a review from a team as a code owner June 22, 2026 11:01
@mydea mydea requested review from JPeer264 and andreiborza and removed request for a team June 22, 2026 11:01
Comment thread dev-packages/node-integration-tests/suites/tracing/mysql/test.ts
Comment thread dev-packages/node-integration-tests/suites/tracing/mysql/scenario-streamError.mjs Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ce514a8. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant