fix(browser): Ensure url.full and http.url attributes have the same values on http.client spans#21660
Draft
Lms24 wants to merge 1 commit into
Draft
fix(browser): Ensure url.full and http.url attributes have the same values on http.client spans#21660Lms24 wants to merge 1 commit into
url.full and http.url attributes have the same values on http.client spans#21660Lms24 wants to merge 1 commit into
Conversation
…me values on `http.client` spans
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21639 came from a bug where our browser fetch instrumentation didn't explicitly set
url.fullcausing it to be set by thehttpContextIntegrationwhich writes this attribute onto segment spans. If streaming is enabled,http.clientspans can become segment spans if they happen outside of an ongoing segment span.closes #21639