Skip to content

chore: use official @module-federation/vite #21605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gioboa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: use official @module-federation/vite #21605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/browser-mfe-vite/apps/mfe-header/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"react-dom": "^18.3.1"
},
"devDependencies": {
"@module-federation/vite": "^1.16.8",
"@types/react": "^18.3.5",
"@originjs/vite-plugin-federation": "^1.3.6",
"@vitejs/plugin-react": "^4.3.1",
"vite": "^5.4.0"
}
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/browser-mfe-vite/apps/mfe-header/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import federation from '@originjs/vite-plugin-federation';
import { federation } from '@module-federation/vite';

export default defineConfig({
plugins: [
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/browser-mfe-vite/apps/mfe-one/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"react-dom": "^18.3.1"
},
"devDependencies": {
"@module-federation/vite": "^1.16.8",
"@types/react": "^18.3.5",
"@originjs/vite-plugin-federation": "^1.3.6",
"@vitejs/plugin-react": "^4.3.1",
"vite": "^5.4.0"
}
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/browser-mfe-vite/apps/mfe-one/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import federation from '@originjs/vite-plugin-federation';
import { federation } from '@module-federation/vite';

export default defineConfig({
plugins: [
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/browser-mfe-vite/apps/shell/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"react-dom": "^18.3.1"
},
"devDependencies": {
"@module-federation/vite": "^1.16.8",
"@types/react": "^18.3.5",
"@types/react-dom": "^18.3.0",
"@originjs/vite-plugin-federation": "^1.3.6",
"@vitejs/plugin-react": "^4.3.1",
"vite": "^5.4.0"
}
Expand Down
18 changes: 15 additions & 3 deletions dev-packages/e2e-tests/test-applications/browser-mfe-vite/apps/shell/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import federation from '@originjs/vite-plugin-federation';
import { federation } from '@module-federation/vite';

export default defineConfig({
plugins: [
react(),
federation({
name: 'shell',
remotes: {
mfe_header: 'http://localhost:3032/assets/remoteEntry.js',
mfe_one: 'http://localhost:3033/assets/remoteEntry.js',
mfe_header: {
type: 'module',
name: 'mfe_header',
entry: 'http://localhost:3032/remoteEntry.js',
entryGlobalName: 'mfe_header',
shareScope: 'default',
},
mfe_one: {
type: 'module',
name: 'mfe_one',
entry: 'http://localhost:3033/remoteEntry.js',
entryGlobalName: 'mfe_one',
Comment thread
gioboa marked this conversation as resolved.
shareScope: 'default',
},
},
shared: ['react', 'react-dom'],
}),
Expand Down
Loading