Skip to content

ref(node): Streamline sql-common#21360

Merged
nicohrubec merged 2 commits into
developfrom
nh/streamline-sql-common
Jun 8, 2026
Merged

ref(node): Streamline sql-common#21360
nicohrubec merged 2 commits into
developfrom
nh/streamline-sql-common

Conversation

@nicohrubec
Copy link
Copy Markdown
Member

@nicohrubec nicohrubec commented Jun 8, 2026

Streamlines the vendored @opentelemetry/sql-common:

  • Port upstream unit tests from OTel and expanded the test suite with two more test cases.
  • Removed the eslint-disable and updated the formatting, else nothing to clean up.

Closes #21131

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nicohrubec nicohrubec marked this pull request as ready for review June 8, 2026 09:42
@nicohrubec nicohrubec requested a review from a team as a code owner June 8, 2026 09:42
@nicohrubec nicohrubec requested review from JPeer264 and andreiborza and removed request for a team June 8, 2026 09:42
Comment thread packages/node/src/integrations/tracing/utils/sql-common.ts
/*
* Tests ported from @opentelemetry/sql-common@0.41.2
* Original source: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages/sql-common
* Licensed under the Apache License, Version 2.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Can we SPDX this too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me merge as is then include this in the license pr

@nicohrubec nicohrubec merged commit 7c19ead into develop Jun 8, 2026
174 of 175 checks passed
@nicohrubec nicohrubec deleted the nh/streamline-sql-common branch June 8, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamline @opentelemetry/sql-common

2 participants