fix(node-core): do not print rejection warning in strict mode#21160
Open
mohd-akram wants to merge 1 commit into
Open
fix(node-core): do not print rejection warning in strict mode#21160mohd-akram wants to merge 1 commit into
mohd-akram wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 03a493d. Configure here.
03a493d to
5702627
Compare
cf63627 to
f7b4f95
Compare
This matches the behavior of Node.js.
f7b4f95 to
8a24c8b
Compare
isaacs
requested changes
May 26, 2026
Member
isaacs
left a comment
There was a problem hiding this comment.
I'm a bit confused. I don't think that this actually does match the behavior in Node...?
$ node --unhandled-rejections=strict -e 'Promise.reject("ok")'
node:internal/process/promises:281
reason : new UnhandledPromiseRejection(reason);
^
UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "ok".
at strictUnhandledRejectionsMode (node:internal/process/promises:281:14)
at processPromiseRejections (node:internal/process/promises:413:17)
at process.processTicksAndRejections (node:internal/process/task_queues:105:32) {
code: 'ERR_UNHANDLED_REJECTION'
}
Node.js v26.0.0
Maybe I'm missing the intention. What is the situation that this is supposed to address?
Contributor
Author
|
@isaacs Okay, I don't think I've ever thrown a string as an error, but it seems the behavior is different in Node.js for Error objects vs strings: If it matters, I can adjust the PR to keep the current behavior if the object doesn't have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of Node.js.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).