Skip to content

feat(nextjs): Add top-level applicationKey option#20794

Merged
chargome merged 1 commit into
developfrom
chargome/feat/applicationkey-nextjs
May 11, 2026
Merged

feat(nextjs): Add top-level applicationKey option#20794
chargome merged 1 commit into
developfrom
chargome/feat/applicationkey-nextjs

Conversation

@chargome
Copy link
Copy Markdown
Member

Adds a top-level applicationKey option to SentryBuildOptions so users can configure thirdPartyErrorFilterIntegration without needing experimental or unstable apis. Forwards to both webpack and turbopack.

ref #17384

@chargome chargome self-assigned this May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 26.37 kB - -
@sentry/browser - with treeshaking flags 24.82 kB - -
@sentry/browser (incl. Tracing) 44.24 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 46.46 kB - -
@sentry/browser (incl. Tracing, Profiling) 49.22 kB - -
@sentry/browser (incl. Tracing, Replay) 83.86 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 73.31 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 88.55 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 101.19 kB - -
@sentry/browser (incl. Feedback) 43.53 kB - -
@sentry/browser (incl. sendFeedback) 31.19 kB - -
@sentry/browser (incl. FeedbackAsync) 36.27 kB - -
@sentry/browser (incl. Metrics) 27.65 kB - -
@sentry/browser (incl. Logs) 27.78 kB - -
@sentry/browser (incl. Metrics & Logs) 28.47 kB - -
@sentry/react 28.11 kB - -
@sentry/react (incl. Tracing) 46.49 kB - -
@sentry/vue 31.24 kB - -
@sentry/vue (incl. Tracing) 46.09 kB - -
@sentry/svelte 26.39 kB - -
CDN Bundle 28.95 kB - -
CDN Bundle (incl. Tracing) 46.97 kB - -
CDN Bundle (incl. Logs, Metrics) 30.36 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 48.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 69.68 kB - -
CDN Bundle (incl. Tracing, Replay) 84.37 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 85.42 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 90.16 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 91.26 kB - -
CDN Bundle - uncompressed 84.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 140.53 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 89.17 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 144 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 214 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 259.24 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 262.69 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 272.94 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 276.38 kB - -
@sentry/nextjs (client) 49.01 kB - -
@sentry/sveltekit (client) 44.72 kB - -
@sentry/node-core 60.56 kB +0.02% +8 B 🔺
@sentry/node 165.62 kB +0.01% +9 B 🔺
@sentry/node - without tracing 73.58 kB +0.02% +9 B 🔺
@sentry/aws-serverless 107.74 kB +0.01% +6 B 🔺
@sentry/cloudflare (withSentry) - minified 169.66 kB - -
@sentry/cloudflare (withSentry) 428.38 kB - -

View base workflow run

@chargome chargome marked this pull request as ready for review May 11, 2026 11:56
@chargome chargome requested a review from a team as a code owner May 11, 2026 11:56
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79d9231. Configure here.

});

expect(result.applicationKey).toBe('my-app-key');
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feat PR missing integration or E2E test

Low Severity

This is a feat PR that adds a new top-level applicationKey option, but it only includes unit tests. Per the project review rules, feat PRs are expected to include at least one integration or E2E test. Consider adding an E2E test that verifies the applicationKey option works end-to-end for either webpack or turbopack builds, similar to the existing browser-webworker-vite E2E test that exercises applicationKey.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 79d9231. Configure here.

@chargome chargome requested a review from nicohrubec May 11, 2026 12:04
@chargome chargome merged commit ca83ba9 into develop May 11, 2026
79 checks passed
@chargome chargome deleted the chargome/feat/applicationkey-nextjs branch May 11, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants