feat(node): Add a dirty version of transports#1316
Merged
Conversation
HazAT
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an internal method
NodeBackend.setTransportthat can take any module or object that looks like thehttpobject. This is actually required by getsentry/sentry-electron#73 to use theelectron.netmodule instead of node's own http implementation.Since we do not have a clear design specification for transports yet, this API should be considered internal for now.
Details
Usually, we would add a
transportoption to the SDKs, just like raven-node and raven-js already have it. However, this approach would have two significant drawbacks:Instead, we can now manually set a transport to the backend instance directly using the
setTransportsetter. It needs to implement the exact signature of http.request.For an example, have a look at ElectronBackend.