Repository navigation
fix(client-reports): Count spans in batched span envelope items - #6265
Open
0xadam-brown wants to merge 1 commit into
Open
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
0xadam-brown
force-pushed
the
fix/client-report-span-item-count
branch
from
October 15, 2026 12:14
a8bc7a4 to
d2ca03c
Compare
0xadam-brown
marked this pull request as ready for review
October 15, 2026 12:15
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 15, 2026 12:15
📲 Install BuildsAndroid
|
buenaflor
reviewed
Oct 15, 2026
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
ah thanks, seems like I missed adding this when doing span-streaming 👍
LGTM but I'll let someone else from Java/Android give the final approval
Member
Author
Ah, nw, and it sounds like a lot of others may have missed it too. Apparently the spec wasn't clear prior to Lukas' recent update. Just wanted to make sure you knew about the change 🙌 |
Prior to this commit, `ClientReportRecorder` didn't have any explicit logic for dealing with span envelopes because sentry-java didn't implement them. That meant that any span envelopes created by hybrid SDKs (in particular sentry-dart) and dropped by sentry-java would be shunted to the recorder's fallback branch and wrongly register a single dropped span per dropped envelope, rather than the actual number. This commit adds the missing span envelope logic. Now sentry-java will report the actual span count, rather than 1. Refs [sentry-docs#19854](getsentry/sentry-docs#19854) # Conflicts: # CHANGELOG.md
0xadam-brown
force-pushed
the
fix/client-report-span-item-count
branch
from
October 16, 2026 13:33
d2ca03c to
fed4e9a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Prior to this PR,
ClientReportRecorderdidn't have any explicit logic for dealing with span envelopes because sentry-java didn't implement them. That meant that any span envelopes created by hybrid SDKs (in particular sentry-dart) and dropped by sentry-java would be shunted to the recorder's fallback branch and wrongly register a single dropped span per dropped envelope, rather than the actual number.This PR fixes adds the missing span envelope logic. Now sentry-java will report the actual span count, rather than 1.
cc @buenaflor
💡 Motivation and Context
Motivated by the Slack convo here and sentry-docs#19854.
Approach matches what we already do for dropped metrics and logs.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps