perf(core): [SDK Overhead Reduction 12] Avoid cloning Date getters#5603
Draft
adinauer wants to merge 1 commit into
Draft
perf(core): [SDK Overhead Reduction 12] Avoid cloning Date getters#5603adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
This was referenced Jun 23, 2026
Merged
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead Reduction)
📜 Description
Avoid cloning mutable
Datevalues from SDK data model getters. These getters now return the storedDatereference directly, matching the broader SDK behavior of exposing mutable model data through getters.💡 Motivation and Context
The SDK already returns mutable internals for many model fields, including maps, lists, arrays, and
Device.timezone. CloningDatevalues on every getter call adds allocation overhead without providing consistent immutability across the SDK data model surface.💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.BreadcrumbTest --tests io.sentry.SentryEventTest --tests io.sentry.protocol.AppTest --tests io.sentry.protocol.DeviceTest --tests io.sentry.protocol.SessionSerializationTest --tests io.sentry.SessionAdapterTest./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog